Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tag matching problems for special characters like + (Trac #1089) #1089

Closed
elgg-gitbot opened this issue Feb 16, 2013 · 8 comments
Closed

tag matching problems for special characters like + (Trac #1089) #1089

elgg-gitbot opened this issue Feb 16, 2013 · 8 comments

Comments

@elgg-gitbot
Copy link

Original ticket http://trac.elgg.org/ticket/1089 on 39489778-05-11 by cash, assigned to unknown.

Elgg version: 1.5

Problem 1: If a user enters the tag "C++", it ends up giving a 404 error when the tag is clicked.

Solution: in the view "output/tags", double urlencode the tag string that is part of the url

Problem 2: If a user enters the tag "C/C++", it gives a 404 error. If the above fixed is used, it matches to the tag "C".

Solution:
in engine/lib/entities, function search_page_handler(), add this line before calling set_input():
$page = implode("/", $page);

@elgg-gitbot
Copy link
Author

trac user marcus wrote on 39514244-12-01

Both are falling foul of the rewrite rules here.

@elgg-gitbot
Copy link
Author

brettp wrote on 39514519-10-15

(In [svn:3392]) Refs #1089: Added [B] flag to rewrite for tags. Won't work until apache 2.2.12. Cleaned up some query code in pagehandler().

@elgg-gitbot
Copy link
Author

brettp wrote on 39514520-10-31

This is a problem with how apache's mod rewrite redirects. The solution is to use the [B] flag to force escaping back references during rewrites. Unfortunately this flag is broken until Apache 2.2.12. (See: https://issues.apache.org/bugzilla/show_bug.cgi?id=45529).

@elgg-gitbot
Copy link
Author

cash wrote on 39573088-08-27

The current solution causes a 500 internal server error with some Apache versions (2.0.52 for example).

@elgg-gitbot
Copy link
Author

brettp wrote on 39579849-11-22

(In [svn:3417]) Refs #1089: Removed [B] flag from htaccess. This flag is wildly inconsistent in functionality and support in Apache. Will have to implement a solution in PHP.

@elgg-gitbot
Copy link
Author

Title changed from tag matching problems to tag matching problems for special characters like + by cash on 39896237-08-11

@elgg-gitbot
Copy link
Author

Milestone changed to Elgg 1.8 by brettp on 40084999-06-21

@elgg-gitbot
Copy link
Author

brettp wrote on 40766162-05-27

Fixed as part of the new htaccess rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant