Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add friends and validation (Trac #1497) #1497

Closed
elgg-gitbot opened this issue Feb 16, 2013 · 4 comments
Closed

add friends and validation (Trac #1497) #1497

elgg-gitbot opened this issue Feb 16, 2013 · 4 comments
Labels
engine worksforme
Milestone
Elgg 1.7

Comments

@elgg-gitbot
Copy link

Original ticket http://trac.elgg.org/ticket/1497 on 40110236-04-03 by trac user durangod, assigned to unknown.

Elgg version:

upon testing the core on a fresh clean install with no install issues i did discover that if you add a friend, and then as the friend you click on the email link it takes you to the reg page, all is well,
but if you mistype the captcha you get the message that the captcha did not pass but you do (unknowingly)get another validation email. so not being aware of that you try to register again and you are successful but it tells you to validate again,
so you go check your email and you find that you have two validation emails there waiting for you..

first there is not need to revalidate after you have clicked the validation from an invited.
second there is not need to validate if the captcha fails

as far as the rest of the process it works fine, when i was able to log in i check my friends and i had a new friend, that part worked perfect...

this was the new 1.7 beta by the way
@elgg-gitbot
Copy link
Author

brettp wrote on 40139801-01-09

I don't quite understand this bug report. The email sent after you add a friend only contains a link to the friending person's profile, not the registration page.

Could you please more clearly explain the steps to reproduce this bug? Thanks.

@elgg-gitbot
Copy link
Author

cash wrote on 40144341-08-22

This is what I think he did:

  • used the invite friends plugin to send invitation
  • friend clicked link and went to registration page
  • friend registered but did not get captcha correct
  • elgg forwards friend to home page and pops up error message

There are no validation emails sent at this point so I don't follow the rest of his ticket. I was unable to figure out how he could get validation emails because the captcha fails the action before it starts. There is no user at this point.

It is annoying that Elgg forwards a user to the home page and forgets your input if you miss the captcha. This is because the captcha is implemented through a plugin hook in the action() function.

@elgg-gitbot
Copy link
Author

trac user durangod wrote on 40148444-02-27

my apologies, all your notices went to my junk mail regarding this ticket and i did not get them till just now..

i will attempt to duplicate this again and let you know asap, thanks

@elgg-gitbot
Copy link
Author

brettp wrote on 40166244-08-11

Since there's no more information about this I'm closing it as worksforme. Though it is annoying that the form doesn't retain its content, sticky forms are a completely different issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
engine worksforme
Milestone
Elgg 1.7
Development

No branches or pull requests
1 participant
@elgg-gitbot