trac user costelloc wrote on 39003343-10-09

To reproduce: add a widget to your dashboard, save, edit page again and add that same widget. Some widgets show some bad behavior when more than one exists on a page. The twitter widget is an example of that. The description above says the status widget is another.

The problem is that the multiple variable is not being used to prevent multiple widgets from being added to a page when a user edits a page more than once. views/default/canvas/layouts/widgets.php (or a function in the engine) would need to check what current widgets are on the page and then remove those from the widget list that have the multiple variable set to false.

trac user costelloc wrote on 39005364-08-16

I just noticed that this is the same as #472.

Also, I wouldn't describe this as trivial for 2 reasons:

1. This can create some very strange behavior with widgets and there is not anything that plugin developers can do about it.
2. It points out there are some incomplete portions of the widget handling code. Even if the multiple flag is set in the widget handler array, it isn't used for anything as far as I can tell. If a plugin sets the multiple flag to true, a user still can't add that widget to a profile page more than once in a edit page session. (Tested with 1.2)

Related bug in views/default/canvas/layouts/widgets.php:

<input type="hidden" name="multiple" value="<?php if ((isset($widget->handler)) && (isset($widgettypes[$widget->handler]->multiple))) echo $widgettypes[$widget->handler]->multiple; ?>" />

The above doesn't work since a widget doesn't have a variable named handler. It should be:

<input type="hidden" name="multiple" value="<?php if (isset($widget->multiple)) echo $widget->multiple; ?>" />

The same goes for side and main hidden inputs but those might be vestigial code anyway since the profile and dashboard are 3 column.

trac user marcus wrote on 39005491-09-12

Well spotted, closing this in favour of #472.