trac user jonkemp wrote on 39088548-08-10

Just noticed that tags in Elgg do not follow the tag mciroformat. Here is the code for tags in Elgg.

Elgg

This is what the microformat specification states.

Tags may only be placed in the URL path, and only in the last segment of the path. Tags may not be placed in query parameters or fragment identifiers.

This is the correct format called for in the specification.

Elgg

So tag urls need to be rewritten in Elgg to correctly follow the specification. But they still require the rel="tag" attribute.

trac user jonkemp wrote on 39088813-04-10

I rewrote the tag url format to follow the microformat specification and I added a rewriterule to .htaccess to handle the url and still display the tag.

Attachment added by trac user jonkemp on 39088815-08-26: 2627_rel_tag.diff

trac user jonkemp wrote on 39090088-06-16

Actually, the code above is wrong, here is what I meant it to be.

Here is the code for tags in Elgg.

Elgg

This is the correct format called for in the specification.

Elgg

The correct format should have rel="tag" and Elgg currently does not.

trac user jonkemp wrote on 39090092-04-28

Replying to jonkemp:

Argh, wrong again. Here is what it should be.

This is the correct format called for in the specification.

Elgg

Anyway, the diff file I posted has the correct code.

benwerd wrote on 39098231-06-03

(In [svn:2642]) Tag URLs now conform to the microformats specification. Fixes #729

benwerd wrote on 39098233-02-06

This has been merged in, although I rewrote the rewrite rule to only match tag/ (as I wasn't confident it wouldn't match other URLs we might use in the future).

trac user jonkemp wrote on 39099789-02-21

Line 128 needs to be rewritten from this.

RewriteRule ^tag/([A-Za-z0-9\+-]+)/?$ search/?tag=$2

to this

RewriteRule ^tag/([A-Za-z0-9\+-]+)/?$ search/?tag=$1

benwerd wrote on 39100614-04-27

Whoops, well spotted! Corrected.