Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User generated content in HTML should not just be commented out (Trac #882) #882

Closed
elgg-gitbot opened this issue Feb 16, 2013 · 2 comments
Closed

User generated content in HTML should not just be commented out (Trac #882) #882

elgg-gitbot opened this issue Feb 16, 2013 · 2 comments
Labels
engine

Comments

@elgg-gitbot
Copy link

Original ticket http://trac.elgg.org/ticket/882 on 39202955-04-15 by trac user kevinjardine, assigned to unknown.

Elgg version: 1.5

Since user generated content can contain strings such as "-->" or "--", using HTML comments to attempt to remove it from display can lead to unexpected results that break the page layout.

An example (for Firefox) is here:

http://community.elgg.org/pg/bookmarks/carbonero/read/34296/featplug--featplug

and an explanation is in my comments in this thread:

http://community.elgg.org/mod/groups/topicposts.php?topic=32565&group_guid=23300

Although the specific example is broken only in Firefox, it would be easy to create an example that would break the layout in any browser.
@elgg-gitbot
Copy link
Author

trac user marcus wrote on 39213171-12-04

On what pages does this occur, is it isolated to bookmarks?

@elgg-gitbot
Copy link
Author

trac user marcus wrote on 39246120-03-01

I believe that the issue highlighted in the link has been fixed in [svn:3176] for #914, please confirm that this has resolved your issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
engine
Milestone
No milestone
Development

No branches or pull requests
1 participant
@elgg-gitbot