Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade jquery to 1.3 (Trac #941) #941

Closed
elgg-gitbot opened this issue Feb 16, 2013 · 5 comments
Closed

upgrade jquery to 1.3 (Trac #941) #941

elgg-gitbot opened this issue Feb 16, 2013 · 5 comments
Labels
engine feature important

Comments

@elgg-gitbot
Copy link

Original ticket http://trac.elgg.org/ticket/941 on 39245786-10-30 by trac user d4niel, assigned to trac user pete.

Elgg version: 1.2

Jquery has a major upgraded version (currently 1.3.2) from 1.2.6. according to jquery teams, 1.3.2 performs much better than 1.2 and has some important new methods (e.g: live methods).

i have tried to upgrade elgg 1.5 with jquery 1.3.2 and for now it all works fine, these are the files need to be changed:

views/default/page_elements/header.php

all css links must be put BEFORE scripts, change to jquery-1.3.2-min.js and jquery-ui-1.7.1.custom.min.js

the jquery-ui script needs some change because i believe elgg uses a personalized version, but 1.7.1.custom.min.js works fine for me(the full packed version with smooth theme)

also, these files need modification due to jquery 1.3's policy of replacing the [att=val] with only [attr=val]. replace all [@ with [ does the job.

mod/blog/views/default/blog/forms/edit.php

mod/embed/views/default/embed/addcontentjs.php

mod/messages/views/default/messages/forms/view.php

mod/notifications/views/default/notifications/subscriptions/jsfuncs.php

mod/tinymce/views/default/input/longtext.php

views/default/embed/addcontentjs.php

views/default/js/initialise_elgg.php

other jquery plugins work fine so far as I've tested.
Hope this helps:-)
@elgg-gitbot
Copy link
Author

trac user d4niel wrote on 39245790-09-23

sorry, Version should be 1.5

@elgg-gitbot
Copy link
Author

trac user pete wrote on 39245836-04-18

Very helpful. Thanks d4niel.

Some additional notes here:
http://community.elgg.org/mod/groups/topicposts.php?topic=34819&group_guid=23300

@elgg-gitbot
Copy link
Author

trac user d4niel wrote on 39245888-04-07

Thanks pete.

for the widget reorder issue, from my experience it's due to the css files not loaded before jquery, which is required as in jquery 1.3 doc. after i change that in header.php the reorder works for me.

Replying to pete:

Very helpful. Thanks d4niel.

Some additional notes here:
http://community.elgg.org/mod/groups/topicposts.php?topic=34819&group_guid=23300

@elgg-gitbot
Copy link
Author

trac user d4niel wrote on 39248760-10-26

ok, another change is needed in header.php

because embed mod extends the metatags view with some javascript, the metatags code must be put after jquery script, e.g:

<script type="text/javascript" src="<?php echo $vars['url']; ?>vendors/jquery/jquery-1.3.2.min.js"></script>
<script type="text/javascript" src="<?php echo $vars['url']; ?>vendors/jquery/jquery-ui-1.7.1.custom.min.js"></script>
<script type="text/javascript" src="<?php echo $vars['url']; ?>_css/js.php?lastcache=<?php echo $vars['config']->lastcache; ?>&js=initialise_elgg&viewtype=<?php echo $vars['view']; ?>"></script>
<?php
  echo $feedref;
  echo elgg_view('metatags',$vars);
?>

@elgg-gitbot
Copy link
Author

trac user pete wrote on 39500318-04-28

(In [svn:3371]) update to jquery 1.3.2 and jqueryUI 1.7.2 closes #941

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
engine feature important
Milestone
No milestone
Development

No branches or pull requests
1 participant
@elgg-gitbot