Opened 4 years ago
Last modified 11 months ago
#1124 reopened Enhancement
Postgres support
| Reported by: | bettse | Owned by: | bettse |
|---|---|---|---|
| Priority: | normal | Milestone: | Long Term Discussion |
| Component: | Core | Version: | 1.5 |
| Severity: | major | Keywords: | |
| Cc: | cash.costello.nospam@…, bettse, brettp | Difficulty: |
Description (last modified by cash)
As mentioned in the emails to the elgg-developer list, the team I'm work has added support for Postgres to Elgg 1.5 using ADODB. I plan to attach patches to this ticket using the same plan laid out in my email to the development email group:
1) Submit diffs against trunk for more portable SQL statements (these would be things like inserts using () values () instead of "set"). 2) Submit diffs against trunk to correct PHP that results in non-portable statements in SQL (things like value='' when it should be value=0) 3) Submit diffs against trunk to add the adodb library and the necessary changes to have it handle db interaction 4) Submit diffs against trunk for more portable SQL through the use of adodb functions (things like Replace, SQLDate, etc) 5) Submit diffs against trunk to add configuration values to allow Postgres to be selected as a db type, and add a postgres.sql db setup script)
We worked off the Elgg 1.5 tarball, so my patches will be against that so as to prevent overlap/conflicts in the diff with new changes to the code base. If some patches don't cleanly apply due to larger changes made to the code base, I can do diffs against the SVN on an as-needed basis.
Attachments (18)
Change History (27)
Changed 4 years ago by bettse
Changed 4 years ago by bettse
Changed 4 years ago by bettse
Changed 4 years ago by bettse
Changed 4 years ago by bettse
Changed 4 years ago by bettse
Changed 4 years ago by bettse
Changed 4 years ago by bettse
Changed 4 years ago by bettse
Changed 4 years ago by bettse
Changed 4 years ago by bettse
Changed 4 years ago by bettse
Changed 4 years ago by bettse
Changed 4 years ago by bettse
Changed 4 years ago by bettse
comment:1 Changed 4 years ago by cash
- Cc cash.costello.nospam@… added
comment:2 Changed 4 years ago by bettse
- Cc bettse added
comment:3 Changed 3 years ago by brettp
- Cc brettp added; ben removed
- Resolution set to Moved to extensions
- Status changed from new to closed
comment:4 Changed 3 years ago by brettp
- Resolution Moved to extensions deleted
- Status changed from closed to reopened
comment:5 Changed 3 years ago by brettp
Ignore previous action.
comment:6 Changed 20 months ago by cash
- Milestone changed from Elgg 2.0 to Future Release
comment:7 Changed 18 months ago by cash
- Milestone changed from Long Term Future Release to Long Term Discussion
comment:8 Changed 16 months ago by cash
- Priority changed from high to normal
comment:9 Changed 11 months ago by cash
- Description modified (diff)
I never realized these patches remove MySQL-specific syntax in favor of standard syntax that would have worked on MySQL. I had always assumed this was making the syntax Postgres specific. Ugh. We should have pulled this in so much earlier.

Diff for access.php to modify SQL for portability