We have moved to Github. Please open tickets there.

Opened 4 years ago

Closed 3 years ago

#1208 closed Enhancement (fixed)

view 'input/button' defaults to submit

Reported by: coldtrick Owned by: ewinslow
Priority: low Milestone: Elgg 1.8.0
Component: UI/UX Version: 1.5
Severity: annoying Keywords:
Cc: brettp, Difficulty: trivial

Description

why does an elgg_view("input/button") default to a submit button?

if I need a button I have to set the type in the view. This is very annoying. If I wanted a submit button I would use "input/submit"

please default it to a button

present in Elgg 1.5 and 1.6

Change History (8)

comment:1 Changed 3 years ago by cash

  • Priority changed from minor to trivial
  • Type changed from unconfirmed defect to enhancement

Why I agree that it would be better to default to 'button', changing it now would break plugins that already assume it defaults to 'submit'.

comment:2 Changed 3 years ago by brettp

  • Milestone changed from Elgg 1.7 to Elgg 1.8
  • Priority changed from trivial to minor

Since UI/UX and views are being refactored for 1.8 and plugins will need to be rewritten for that, we can change it then.

comment:3 Changed 3 years ago by brettp

  • Difficulty set to trivial
  • Priority changed from normal to low
  • Severity changed from minor to annoying

comment:4 Changed 3 years ago by brettp

  • Cc marcus removed

comment:5 Changed 3 years ago by cash

  • Component changed from Core to UI/UX

comment:6 Changed 3 years ago by ewinslow

  • Owner set to ewinslow
  • Status changed from new to assigned

comment:7 Changed 3 years ago by ewinslow

(In [svn:7307]) Refs #1208: Default input/button to 'button' type (rather than 'submit' type).

comment:8 Changed 3 years ago by ewinslow

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.