We have moved to Github. Please open tickets there.

Opened 4 years ago

Closed 3 years ago

#1223 closed Defect (fixed)

notify_user() should throw an exception if something is wrong with a handler

Reported by: cash Owned by:
Priority: normal Milestone: Elgg 1.7.1
Component: Core Version: 1.6
Severity: minor Keywords:
Cc: marcus, brettp, Difficulty:

Description

Current code:

	if ((!$NOTIFICATION_HANDLERS[$method]) || (!$handler))
		error_log(sprintf(elgg_echo('NotificationException:NoHandlerFound'), $method));

This writes the exception to the log and then produces a WSOD when it tries to run the bad handler. Shouldn't it throw an exception and stop execution?

Change History (3)

comment:1 Changed 3 years ago by brettp

  • Milestone changed from Elgg 1.7 to Elgg 1.8

comment:2 Changed 3 years ago by cash

  • Milestone changed from Elgg 1.8 to Elgg 1.7.1

comment:3 Changed 3 years ago by cash

  • Resolution set to fixed
  • Status changed from new to closed

(In [svn:5592]) Fixes #1223 - skip notification methods that no longer exist

Note: See TracTickets for help on using tickets.