brettp wrote on 39816043-11-25

Is this in 1.6 or trunk? If trunk, it would likely be a result of the new search.

cash wrote on 39816219-09-17

Sorry - didn't realize trunk was an option in the version drop down. It is trunk.

brettp wrote on 39816248-12-27

It wasn't an option but I had a hunch it should be ;)

Justin, if you don't mind, I've assigned this to you since it's concerning search. If you don't have time to check it out, feel free to assign it back to me and I'll have a look when I can. Thanks...

trac user jricher wrote on 39821118-05-18

Looks like Cash has it right. Do we have a list of such reserved variable names someplace? (Things like $CONFIG and $vars would go in there, too.)

cash wrote on 39821141-02-17

I've bumped into this type of thing enough that I've thought about documenting this on the wiki. Never got around to it. I'll at least create a page for it: http://docs.elgg.org/wiki/What_variables_are_reserved_by_Elgg%3F

Attachment added by trac user jricher on 39829653-02-18: search-viewtype.diff

cash wrote on 39959295-11-19

It looks like this has been partially patched. I still think there is possible issues in - I think the variable viewtype should be reserved and these files use it to refer to gallery versus lists rather than the standard default vs rss viewtype.

/mod/search/views/default/search/entity_list.php

/views/default/entities/entity_list.php

/views/default/navigation/viewtype.php

Milestone changed to Elgg 1.8 by brettp on 40089635-03-08

Title changed from elgg_view_entity_list() is broken to Document all reserved get/post variables by brettp on 40089635-03-08

Title changed from Document all reserved get/post variables to Fix misused reserved var names by brettp on 40766449-11-18

brettp wrote on 40773908-09-07

Rels #2334.

cash wrote on 41144900-01-10

Looks like all the viewtype confusion has been cleaned up.

This is now a documentation ticket and we'll move it back.

Milestone changed to Elgg 1.8.1 by cash on 41144900-01-10

Title changed from Fix misused reserved var names to Document reserved var names like viewtype by cash on 41144900-01-10

Milestone changed to Documentation by cash on 42070148-05-20

Closing because:

• I don't see this ever happening in a heroic single-pass close-the-ticket kind of way.
• Nor do I ever see it being "complete". This will be an ongoing process as the code keeps evolving.
• No activity in years