Opened 4 years ago
Closed 3 years ago
#1356 closed Defect (fixed)
commit [3572] breaks all themes by changing div search_listing to entity_listing
| Reported by: | cash | Owned by: | |
|---|---|---|---|
| Priority: | high | Milestone: | Elgg 1.7 |
| Component: | Core | Version: | 1.6 |
| Severity: | major | Keywords: | |
| Cc: | brettp, jricher | Difficulty: |
Description
This is in the entity_listing.php view. I agree that entity_listing is a better name for the div but it breaks all current themes. Is there another reason for breaking the themes than having a more accurate name?
As an example, the groups plugin uses some css for .groups .search_listing.
If I were a theme creator, I'd be very annoyed by this change.
Change History (7)
comment:1 Changed 4 years ago by jricher
comment:2 Changed 4 years ago by brettp
If the theme overrides page_elements/topbar.php the change we've made in core won't break the theme because the original search and the new search both use the same form action URL.
The changed div is a larger problem because it will break all themes immediately.
comment:3 Changed 4 years ago by brettp
Apparently this is only half true--Some themes use URL/search and some used URL/pg/search
comment:4 Changed 4 years ago by jricher
I saw that this was reverted -- in which case, can we put a roadmap point to 2.0 or some other feature-incompatible version of Elgg? But I still think that with all the changes we're already doing to the core API as it is, it's a good time to break things once and have that be that.
comment:5 Changed 4 years ago by cash
There are many in the community who are extremely sensitive to new versions of Elgg breaking things. Elgg 1.7 has been promised as being backward compatible. I think Brett has made sure the API changes have backward compatible wrappers.
comment:6 Changed 4 years ago by brettp
CODING.txt has a short bit about deprecating APIs, but nothing's been drawn together for themes yet. Since Pete does most of the work with themes, we'll talk to map out a good procedure for handling theme upgrades
The API in 1.7 should be backward compatible with 1.6's. I'm preparing a developer's release to start the ball rolling on testing these changes.
comment:7 Changed 3 years ago by brettp
- Resolution set to fixed
- Status changed from new to closed
Since reverting the themes should be compatible again. Marking this one off.
We're breaking themes with the new search code anyway, as the views have been broken up (the searchbox in the topbar, for example). The main reason for the change is a better fit for the name, but also so that the search listing can be styled differently from a generic entity listing if desired. For example, search listings now (should at least) have the "matched on" field tacked beneath the entity listing itself.
Profile and Group should be moved to the new style; they weren't in the core repository, so I couldn't include them in my patch at the time.