isset() incorrect for metadata

[twall]

Assigning a value of zero to an object field results in the field reported as "unset". This is true whether the field persistence is backed by metadata (objects/entities) or private settings (widgets).

$obj->metadata = 1;
assertTrue(isset($obj->metadata));

$obj->metadata = 0;
assertTrue(isset($obj->metadata));

unset($obj->metadata);
assertFalse(isset($obj->metadata));

[brettp]

The same is true of $obj->metadata = ; Will need to create a few helper functions like metadata/private_setting_exists($guid, $md_name) to check if that metadata is registered against that entity as a name_id.

[brettp]

It's occurred to me the OP is probably having problems checking widget settings where a possible option is 0. Setting this back to "major."

[twall]

Yes, that is *exactly* what I was having problems with. An integer position, when it has value zero, shows up as "unset".

[cash]

Why not implement isset()?

[cash]

Grrr... that should be

__isset()

[brettp]

isset() is implement, only poorly. We need to see if the metadata exists at all for the entity, regardless of its value. The current isset() returns metadata value != . We could make a simple exemption for ints, though...

[cash]

Oh, I see. I missed that.

Change the code to:

return $this->$name !== NULL;

That should work.

[brettp]

Indeed it does...I didn't realize the metadata fetching functions were that fleshed out. Definitely the simplest solution ;)

[brettp]

(In [svn:3803]) Fixes #1414: Metadata set to a falsy value (except NULL) returns TRUE for isset($obj->md).