Opened 3 years ago
Closed 3 years ago
#1442 closed Defect (Closed)
Updated Search Views
| Reported by: | markharding | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | Elgg 1.7 |
| Component: | Core | Version: | Github Master |
| Severity: | minor | Keywords: | |
| Cc: | brettp | Difficulty: |
Description
I have made minor changes to the views of the search plugin
Attachments (3)
Change History (16)
comment:1 Changed 3 years ago by brettp
comment:2 Changed 3 years ago by markharding
I use tortoise svn. I just clicked create patch and then uploaded it - do you know how I can convert it?
comment:3 Changed 3 years ago by brettp
It would be an editor preference...you want to use LF instead of CR + LF.
comment:4 Changed 3 years ago by markharding
is the newest one better?
comment:5 Changed 3 years ago by brettp
These are just zipped versions of the full files with CR+LF...so no :) Why not hop on freenode in #elgg sometime and I'll help you out...
Changed 3 years ago by markharding
comment:6 Changed 3 years ago by markharding
third time lucky - i sued a dos2unix converter for this one
comment:7 Changed 3 years ago by cash
What editor are you using? If you want to use a text-editor Notepad++ does a good job with line endings. If an IDE, I'd think any of them would work (eclipse, netbeans,...).
Most will keep the same line endings as the file originally had. Others will always convert all line endings to what you've configured them to use.
comment:8 Changed 3 years ago by markharding
I edited it in dreamweaver cs4 and then created the patch with tortoise svn - i run windows 7. can you read the latest file ■searchupdate.dif?
comment:9 Changed 3 years ago by cash
No - it still shows the entire file as being changed. I'm pretty sure Dreamweaver on Windows defaults to CRLF line endings. I think you'll need to either change a preference in Dreamweaver or use some other editor when you want to make patches.
Changed 3 years ago by markharding
Changed 3 years ago by markharding
comment:10 Changed 3 years ago by markharding
ok, so i was playing around in dreamweaver and came accross code format. I changed it to LF (Unix).
I have attached the patch and the files in the zip.
comment:11 Changed 3 years ago by cash
Yes, that works now. A short description of what you're trying to do would be helpful also.
comment:12 Changed 3 years ago by markharding
I have modified the files to make the UI more user friendly.
comment:13 Changed 3 years ago by brettp
- Resolution set to Closed
- Status changed from new to closed
The patch has a few oddities with CSS formatting on the default theme so I'm not pulling it into 1.7. @Mark you might want to join the discussion at http://community.elgg.org/mod/groups/topicposts.php?topic=397103&group_guid=212846 about standardizing Elgg's UI. The search interface will be part of the eventual UI overhaul and we'll be glad to have your input.
I appreciate the patch but the new files were saved with the incorrect EOL character--We use Unix-style in Elgg. This means the diffs show the entire files instead of just the changes you made. Could you please convert to unix-style and re-upload? Thanks.