We have moved to Github. Please open tickets there.

Opened 3 years ago

Closed 2 years ago

#1553 closed Enhancement (fixed)

Make sure entities use getURL() methods throughout core

Reported by: jaakko.naakka Owned by:
Priority: normal Milestone: Elgg 1.8.0
Component: Core Version: 1.7
Severity: minor Keywords: profile urls, relationship, add friend, email
Cc: brettp Difficulty: easy

Description

The function relationship_notification_hook in relationships.php sends a notification to a user when someone adds them as a friend. The email includes a link to the user's profile which is created as

$CONFIG->site->url . "pg/profile/" . $user_one->username

Shouldn't this be simply

$user_one->getURL()

This is a small problem for anyone who has changed the user profile url format.

Attachments (1)

relationship_notification_hook.patch (751 bytes) - added by jaakko.naakka 3 years ago.

Download all attachments as: .zip

Change History (6)

Changed 3 years ago by jaakko.naakka

comment:1 Changed 3 years ago by brettp

(In [svn:3974]) Refs #1553: Corrected profile link in friending notification.

comment:2 Changed 3 years ago by brettp

  • Milestone changed from Elgg 1.7 to Elgg 1.8
  • Summary changed from Use getURL() to point to user's profile when added a friend to Make sure entities use getURL() methods throughout core

comment:3 Changed 3 years ago by brettp

  • Difficulty set to easy

comment:4 Changed 2 years ago by cash

(In [svn:7756]) Refs #1553 - removed all hard coded profile urls from core

comment:5 Changed 2 years ago by cash

  • Resolution set to fixed
  • Status changed from new to closed

This appears to be done. We'll open a new ticket for individual problems.

Note: See TracTickets for help on using tickets.