GROUP Forum Plugin - When Admin edits a post he owns it afterwards

[Dahaniel]

When I as an admin edit a post in a group forum, I am displayed as creator of the post.

The creator should be kept, optionally a "edited by: at:" could be added to the post. (but this should be optional)

[Dahaniel]

It is actually in 1.2

[Dahaniel]

Just had a look in the Database. The actual post entity is still belonging to the author but the corresponding annotation now belongs to the editor (me in this case) which makes ma appear as the author in the forum.
For now I fixed it manually but I think the owner should not change upon editing.

[kevinjardine]

I believe that the fix is to delete line line 29 in

mod/groups/actions/forums/edittopic.php

This is:

$user = $_SESSION['user']->getGUID();

It is incorrect to set the user to the currently logged in user as
this is used to update the annotation.

After line 36, which is:

$topic = get_entity($topic_guid);

add:

{{$user = $topic->getOwner();}}

[kevinjardine]

D!*n trac.

This should have been:

I believe that the fix is to delete line line 29 in

mod/groups/actions/forums/edittopic.php

This is:

$user = $_SESSION['user']->getGUID();

It is incorrect to set the user to the currently logged in user as this is used to update the annotation.

After line 36, which is:

$topic = get_entity($topic_guid);

add:

$user = $topic->getOwner();

[kevinjardine]

Just as an aside - I think that the behaviour of update_annotation seems a little strange.

All the parameters are required, even if you don't actually want to change the owner or access_id.

If you set the owner to 0, the function sets the owner to the current logged-in user. Should not the default behaviour of an update function be to leave the values unchanged?

Also, if the update trigger fails, the code appears to delete the annotation. Should not an update failure actually mean that the annotation should be restored to its previous value?