We have moved to Github. Please open tickets there.

Opened 4 years ago

Closed 4 years ago

#1759 closed Defect (fixed)

Updating page gives "new page created" message in river (patch included)

Reported by: edfactor Owned by:
Priority: normal Milestone:
Component: Version:
Severity: Keywords:
Cc: brettp Difficulty:

Description

When you update a page, the river says you created a new one. There are two things needed to fix this:

  • The page that gets the form submission (currently) just calls add_to_river with the create setting no matter what you do. So you need to check to see if it's create or update and make different calls. (this is the file: mod/pages/actions/pages/edit.php)
  • The page that actually does the update (mod/pages/views/default/river/object/page/update.php) doesn't work. My guess is that it hasn't worked in a while. If you look at the create.php page next to it in that directory, you see the changes from when they both had the same logic. The fix is to copy create.php to update.php and change the two instances of the word to "update" from "create".

I did both of these changes and it works fine now.

I have included a diff file against Rev. 29 in svn and attached the diff

Attachments (1)

29_page_update_rivmsg.diff (1.8 KB) - added by edfactor 4 years ago.
Diff for the fix for this bug

Download all attachments as: .zip

Change History (2)

Changed 4 years ago by edfactor

Diff for the fix for this bug

comment:1 Changed 4 years ago by marcus

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.