#1835 closed Defect (fixed)
Decoding HTML entities in blog tags
| Reported by: | codelust | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | Elgg 1.8.5 |
| Component: | Blog | Version: | 1.7 |
| Severity: | minor | Keywords: | |
| Cc: | brettp | Difficulty: | easy |
Description (last modified by brettp)
in blog/view/default/object/blog.php
if (!empty($tags)) {
echo '<p class="tags">' . html_entity_decode($tags) . '</p>';
}
Needs to decode HTML entities.
Change History (8)
comment:1 Changed 16 months ago by cash
- Component changed from Blog to Core
- Milestone set to Needs Review
- Severity set to minor
- Version set to 1.7
comment:2 Changed 16 months ago by cash
If I use the string <test as a tag, it displays correctly in output/tags but not in the tag cloud.
comment:3 Changed 16 months ago by codelust
- Type changed from Enhancement to Defect
Steps to replicate the problem:
- Create a new blog entry.
- Create tags with a "here > there" character or anything similar.
- On the view page it is rendered as "here > there".
- When you go back to the edit page it is rendered in the tags field as "here > there".
This is not the expected behaviour.
comment:4 Changed 13 months ago by brettp
- Description modified (diff)
- Difficulty set to easy
- Milestone changed from Needs Review to Elgg 1.8.5
comment:5 Changed 13 months ago by sembrestels
I think this is solved in the last Elgg 1.8's version. I followed codelust's steps and I don't get the unexpected behaviour.
comment:6 Changed 13 months ago by sembrestels
- Component changed from Core to Blog
comment:7 Changed 13 months ago by Brett Profitt
- Resolution set to fixed
- Status changed from new to closed
Fixes #1835. Passing tagcloud URLs through output/url for proper escaping.
Changeset: c0c5c0f81f40b5d72048e74842a650f974cefcd7
comment:8 Changed 12 months ago by Brett Profitt
Fixes #1835. Passing tagcloud URLs through output/url for proper escaping.
Changeset: c0c5c0f81f40b5d72048e74842a650f974cefcd7

Reviewing tickets that got lost once we started using milestones. I guess people must be pasting html entities into the tag text box. Need to figure out what this ticket means.