Opened 3 years ago
Closed 3 years ago
#1984 closed Defect (fixed)
External pages preview
| Reported by: | darkwingduck | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | Elgg 1.7.1 |
| Component: | External Pages | Version: | 1.7 |
| Severity: | minor | Keywords: | |
| Cc: | brettp | Difficulty: |
Description
There is a preview section commented out in 'external pages' edit form. Guess it was first intended for a preview, then commented out cause it wasn't doing good in an existing page code.
However html comments doesn't prevent it to interfare with the page. If the inserted code has html comments, this makes the preview section interfare. This can lock the admin out of the external pages edit form (like a modal dialog script). This section should better be removed completely.
At:
root/elgg/branches/1.7/mod/externalpages/views/default/expages/forms/edit.php
Also in v1.5
Change History (4)
comment:1 Changed 3 years ago by cash
- Milestone changed from Elgg 1.8 to Elgg 1.7.1
comment:2 Changed 3 years ago by cash
- Resolution set to fixed
- Status changed from new to closed
comment:3 Changed 3 years ago by darkwingduck
- Resolution fixed deleted
- Status changed from closed to reopened
we also need to fix the file in the description.
Btw, does that part have to exist? If it's meant to be an example for people who play on the source, they can echo the part themselves? If it's for future implementation, it may work better having an iframe displaying the actual page, just an opinion.
comment:4 Changed 3 years ago by cash
- Resolution set to fixed
- Status changed from reopened to closed
(In [svn:5420]) Fixes #1984 - missed the echo of description on the edit form for [svn:5413]
(In [svn:5413]) Fixes #1984 - front page preview code is commented out correctly now