brettp wrote on 40204488-09-01

Try to use:

$group = elgg_get_entities(array(
    'type' => 'group',
    'subtype' => ELGG_ENTITIES_NO_VALUE
));

If that doesn't work, please reopen this ticket.

This constant needs to be documented.

lowfill wrote on 40204546-09-11

It works!

The problem now is that it is not the default behavior in the groups plugin. When I show my groups it shows my groups AND my projects.

I'll attach a patch latter.

Attachment added by lowfill on 40204729-05-19: groups_empty_subtype.patch

Attachment added by lowfill on 40204729-12-02: groups_empty_subtype-core.patch

lowfill wrote on 40204731-07-27

Attached patch to groups module and engine/lib/relationships to fix this problem.

cash wrote on 40205447-12-03

The group patch appears to have been done off of the trunk (1.8) rather than the 1.7 branch. I can figure out what it is doing but we need decide what we want the default to be.

The options are

1. groups plugin shows all groups
2. group plugin shows only groups without subtype

Either way some group of people will have to override some group functionality (unless this is made as a parameter). Some people use subtypes to extend the group plugin but expect them to be listed as groups. Others subtype it and want to separate the subtype from the normal groups.

To override this only requires overriding the group page handler for a few pages if this patch does cover everything.

brettp wrote on 40205461-01-26

What is listed by default was discussed for the context of search in #1499. For consistency, I'd argue the bundled plugins should all function the same way when listing users and groups. With search as precedence, this means to list all regardless of subtype.

cash wrote on 40205473-05-26

I agree. Elgg has worked this way for a while. As long as all the pages go through the page handler, this should be easy to change with a plugin.

Diego, you also submitted a patch on the relationships lib. This should probably be its own ticket (though I haven't taken the time to understand what it is doing).

lowfill wrote on 40205753-11-04

The relationships patch comes with the code for fix the method get_entities_from_relationship that is not using the ELGG_ENTITIES_NO_VALUE parameter. I will open a separate ticket for this.

Talking about the groups plugin I think that both behavior should be available through plugin's configuration. It would give to users the freedom to choose what behavior is better for their context without need to change any core code.

cash wrote on 40212997-09-24

Diego, please don't forgot to open a ticket for the relationship patch and explain what is not working so we can test for it.

cash wrote on 40230154-12-07

I'm closing this one. Diego, don't forget to open a ticket for the relationship patch as I've said before.