Attachment added by trac user milan on 40229222-06-06: view.php

ewinslow wrote on 40313412-03-08

Bump for this. It would be a huge performance improvement.

Milestone changed to Elgg 1.9 by brettp on 40769092-12-11

codelust wrote on 41010892-03-08

Can the same be done to mod/profile/icondirect.php ? It has made a massive difference in the performance of my installation.

Attachment added by trac user srokap on 41940789-01-22: cache_handler.php

trac user srokap wrote on 41940804-03-28

This code (see attachment) was already tested, it might be wise to consider other etag generation method, and maybe extract this part to allow reuse in other places like profile/icondirect.php
Also there's an assumption that server supports gzipping the output, I didn't test it in environment without it. Impact on rendering time is significant since downloading main css and js file does not block rendering of page any more.

Title changed from Enhance simplecache to return 304 Not Modified header when appropriate to Enhance simplecache to return 304 Not Modified header when appropriate + support for gzipping dynamically generated output by trac user srokap on 41940804-03-28

cash wrote on 41948645-06-17

I don't think we need to hash the contents of the file. The date encoded in the URL should be good enough to tell whether the file has been updated. If that's true we could just do a hash of the URL for the etag.

Attachment added by trac user srokap on 41959307-11-24: cache_handler.2.php

trac user srokap wrote on 41959312-03-04

We were working on this second version (attachment) without problems. It uses md5 hash from modification date as a etag, hashing the URL itself would be a bit strange to me.

Milestone changed to Elgg 1.8.3 by cash on 42004024-02-16

cash wrote on 42022308-12-10

I'm breaking this up into 3 tickets:

• this ticket will be for ETag
• another for last modified support for cache and icons (profile avatars and group icons)
• another for gzipping

Title changed from Enhance simplecache to return 304 Not Modified header when appropriate + support for gzipping dynamically generated output to Enhance simplecache to return 304 Not Modified header when ETag matches by cash on 42022308-12-10

trac user Cash Costello wrote on 42022354-11-10

Fixes #2002 adds ETag support to simple cache handler
Changeset: d213db7

trac user Cash Costello wrote on 42050554-05-20

Fixes #2002 adds ETag support to simple cache handler
Changeset: d213db7