Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

legacy get_entities_from_annotations function has changed in Elgg 1.7 (Trac #2022) #2022

Closed
elgg-gitbot opened this issue Feb 16, 2013 · 5 comments

Comments

@elgg-gitbot
Copy link

Original ticket http://trac.elgg.org/ticket/2022 on 40240481-11-06 by trac user kevinjardine, assigned to brettp.

Elgg version: 1.7

Before Elgg 1.7, the owner_guid parameter of get_entities_from_annotations referred to the owner_guid of the annotation.

In Elgg 1.7, it is now the owner of the entity the annotation is attached to. This breaks legacy code that depends upon the owner of an annotation.

@elgg-gitbot
Copy link
Author

trac user kevinjardine wrote on 40240484-08-20

I have rated this major because it obviously breaks a significant amount of legacy code using annotations (eg. the event calendar).

@elgg-gitbot
Copy link
Author

cash wrote on 40242653-09-25

elgg_get_entities_from_annotations() does not support annotation owners so that will have to be added before get_entities_from_annotations() can be fixed.

@elgg-gitbot
Copy link
Author

brettp wrote on 40246073-04-29

(In [svn:5557]) Fixes #2022: Added abilty to get entities by metadata/annotation owner_guid. DRY'd up the metadata and annotations SQL. As an added bonus, you can now sort by annotation value if so inclined.

@elgg-gitbot
Copy link
Author

brettp wrote on 40246074-03-19

Should have just been Refs this. The legacy function doesn't rewrite yet.

@elgg-gitbot
Copy link
Author

brettp wrote on 40246127-07-08

(In [svn:5558]) Fixes #2022: get_entities_from_annotations() rewrites owner_guid to annotation_owner_guids. Cleaned up some leftover code. Added maxtime back to select statement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant