direct profile icon link

[cash]

To restore direct profile icon links, we probably need:

• a script that renames profile icons to filenames that use guid rather than username
• store base directory as metadata on user - unless there is an easy way to extract base directory from something already available.

Then the only information needed in the direct link would be base_dir and guid.

See also #1989

[cash]

(In [svn:5567]) Fixes #1989 and refs #2035 - profile icondirect should work for those using CGI

[cash]

Need to make up my mind on the milestone. I'll be committing a temporary fix for this but I recommend pulling username out of the profile icon filenames. This would mean a simpler URL and closes a possible security hole.

[cash]

(In [svn:5713]) #refs #2035 - added profile icondirect back to the 1.7 branch

[brettp]

Completely agree about pulling the username out. The solution in [svn:5713] will work in most cases so I'm ok with leaving it in for 1.7.1 but will like to create a proper migration for 1.7.2.

[cash]

Brett, in what cases won't it work?

[brettp]

@Cash - You're right--It should work in all cases that ever worked (and probably more). I was remembering a username-mangling line that has apparently been always commented out: ​http://trac.elgg.org/browser/elgg/tags/1.5/mod/profile/icondirect.php#L24

[cash]

(In [svn:6687]) Fixes #2035 - profile icons now use user guid rather than usernames - includes upgrade script

[cash]

(In [svn:6688]) Refs #2035 - forgot that people may be upgrading from 1.6 or earlier so cannot reuse same function name that I stole from earlier upgrade script