Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace input/autocomplete and input/userpicker with jQuery UI autocomplete (Trac #2102) #2102

Closed
elgg-gitbot opened this issue Feb 16, 2013 · 18 comments

Comments

@elgg-gitbot
Copy link

Original ticket http://trac.elgg.org/ticket/2102 on 40306678-11-23 by cash, assigned to cash.

Elgg version: 1.7

When Elgg upgrades to UI version 1.8.*, investigate replacing the autosuggest view with UI based code.

@elgg-gitbot
Copy link
Author

Title changed from jQuery UI autocomplete to Replace input/autocomplete and input/userpicker with jQuery UI autocomplete by brettp on 41016411-01-13

@elgg-gitbot
Copy link
Author

cash wrote on 41124885-11-11

Evan, you set severity to major. It currently works as is - though needs CSS. Did you mean to set the difficulty to major?

@elgg-gitbot
Copy link
Author

ewinslow wrote on 41125163-05-24

I think I meant to set priority, since it's a js issue. The API is quite different b/w the current jquery autocomplete and the core jquery-ui autocomplete, so a "major" difficulty seems appropriate as well, though that's not an option.

@elgg-gitbot
Copy link
Author

ewinslow wrote on 41125297-07-24

(In [svn:8240]) Refs #2102: Replaced input/autocomplete with jQuery UI autocomplete (untested)

@elgg-gitbot
Copy link
Author

ewinslow wrote on 41125405-10-01

(In [svn:8242]) Refs #2102: Replace input/userpicker with jQuery UI autocomplete

@elgg-gitbot
Copy link
Author

ewinslow wrote on 41125422-12-16

(In [svn:8245]) Refs #2102: Some input/autocomplete fixes

@elgg-gitbot
Copy link
Author

ewinslow wrote on 41125445-09-16

(In [svn:8246]) Refs #2102: addressing more userpicker/autocomplete bugs

@elgg-gitbot
Copy link
Author

cash wrote on 41430896-11-28

Evan, any status on this? We got this ticket today #3528. The river rework for beta 2 is definitely a higher priority so this is something that I could take a look at while you work on #3404.

@elgg-gitbot
Copy link
Author

ewinslow wrote on 41439432-02-24

Go for it.

@elgg-gitbot
Copy link
Author

brettp wrote on 41642674-02-23

This looks integrated. Is something missing?

@elgg-gitbot
Copy link
Author

brettp wrote on 41642709-06-13

Just kidding. These don't work at all. Any idea about the status of these?

@elgg-gitbot
Copy link
Author

ewinslow wrote on 41652658-07-28

I don't recall the full extent of the problem but I think a few of Ravindra's tickets have to do with autocomplete (the ones tagged gsoc-ajax or something)

@elgg-gitbot
Copy link
Author

brettp wrote on 41678378-04-17

This is getting pushed to 1.8.1 since I have no idea what the status is or if there's a plan for it. Refs #2712.

@elgg-gitbot
Copy link
Author

Milestone changed to Elgg 1.8.1 by brettp on 41678378-04-17

@elgg-gitbot
Copy link
Author

cash wrote on 41686296-12-27

The main dev behind jQuery UI has an extension to their core autocomplete that supports returning JSON objects. When I investigated that looked like the best option.

@elgg-gitbot
Copy link
Author

cash wrote on 41766301-06-27

Here is my progress on this: https://github.com/cash/Elgg/tree/autocomplete

I've simplified the JS significantly by creating the html through the views system rather than creating it with JS.

I still need to style the results and take a look at the userpicker.

@elgg-gitbot
Copy link
Author

trac user Cash Costello wrote on 41796420-01-06

Merge pull request #74 from cash/autocomplete

Fixes #2102, #2712, #3450 Finishes autocomplete and userpicker for 1.8.1
Changeset: 63ebe7b

@elgg-gitbot
Copy link
Author

trac user Cash Costello wrote on 41850785-03-20

Merge pull request #74 from cash/autocomplete

Fixes #2102, #2712, #3450 Finishes autocomplete and userpicker for 1.8.1
Changeset: 63ebe7b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant