We have moved to Github. Please open tickets there.

Opened 3 years ago

Closed 19 months ago

Last modified 19 months ago

#2102 closed Enhancement (fixed)

Replace input/autocomplete and input/userpicker with jQuery UI autocomplete

Reported by: cash Owned by: cash
Priority: high Milestone: Elgg 1.8.1
Component: Core Version: 1.7
Severity: minor Keywords: ui
Cc: brettp Difficulty: moderate

Description

When Elgg upgrades to UI version 1.8.*, investigate replacing the autosuggest view with UI based code.

Change History (20)

comment:1 Changed 3 years ago by brettp

  • Difficulty set to moderate
  • Keywords ui added

comment:2 Changed 2 years ago by brettp

  • Summary changed from jQuery UI autocomplete to Replace input/autocomplete and input/userpicker with jQuery UI autocomplete

comment:3 Changed 2 years ago by ewinslow

  • Owner set to ewinslow
  • Status changed from new to assigned

comment:4 Changed 2 years ago by ewinslow

  • Severity changed from minor to major
  • Status changed from assigned to new

comment:5 Changed 2 years ago by cash

Evan, you set severity to major. It currently works as is - though needs CSS. Did you mean to set the difficulty to major?

comment:6 Changed 2 years ago by ewinslow

  • Priority changed from normal to high
  • Severity changed from major to minor
  • Status changed from new to assigned

I think I meant to set priority, since it's a js issue. The API is quite different b/w the current jquery autocomplete and the core jquery-ui autocomplete, so a "major" difficulty seems appropriate as well, though that's not an option.

comment:7 Changed 2 years ago by ewinslow

(In [svn:8240]) Refs #2102: Replaced input/autocomplete with jQuery UI autocomplete (untested)

comment:8 Changed 2 years ago by ewinslow

(In [svn:8242]) Refs #2102: Replace input/userpicker with jQuery UI autocomplete

comment:9 Changed 2 years ago by ewinslow

(In [svn:8245]) Refs #2102: Some input/autocomplete fixes

comment:10 Changed 2 years ago by ewinslow

(In [svn:8246]) Refs #2102: addressing more userpicker/autocomplete bugs

comment:11 Changed 2 years ago by cash

Evan, any status on this? We got this ticket today #3528. The river rework for beta 2 is definitely a higher priority so this is something that I could take a look at while you work on #3404.

comment:12 Changed 2 years ago by ewinslow

  • Owner changed from ewinslow to cash
  • Status changed from assigned to new

Go for it.

comment:13 Changed 21 months ago by brettp

This looks integrated. Is something missing?

comment:14 Changed 21 months ago by brettp

Just kidding. These don't work at all. Any idea about the status of these?

comment:15 Changed 21 months ago by ewinslow

I don't recall the full extent of the problem but I think a few of Ravindra's tickets have to do with autocomplete (the ones tagged gsoc-ajax or something)

comment:16 Changed 21 months ago by brettp

  • Milestone changed from Elgg 1.8.0 to Elgg 1.8.1

This is getting pushed to 1.8.1 since I have no idea what the status is or if there's a plan for it. Refs #2712.

comment:17 Changed 21 months ago by cash

The main dev behind jQuery UI has an extension to their core autocomplete that supports returning JSON objects. When I investigated that looked like the best option.

comment:18 Changed 20 months ago by cash

  • Status changed from new to assigned

Here is my progress on this: https://github.com/cash/Elgg/tree/autocomplete

I've simplified the JS significantly by creating the html through the views system rather than creating it with JS.

I still need to style the results and take a look at the userpicker.

comment:19 Changed 19 months ago by Cash Costello

  • Resolution set to fixed
  • Status changed from assigned to closed

Merge pull request #74 from cash/autocomplete

Fixes #2102, #2712, #3450 Finishes autocomplete and userpicker for 1.8.1

Changeset: 63ebe7b121105beb7e4c8b9b82e3c649f6a9a489

comment:20 Changed 19 months ago by Cash Costello

Merge pull request #74 from cash/autocomplete

Fixes #2102, #2712, #3450 Finishes autocomplete and userpicker for 1.8.1

Changeset: 63ebe7b121105beb7e4c8b9b82e3c649f6a9a489

Note: See TracTickets for help on using tickets.