Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add admin menu button for refresh cache (Trac #2111) #2111

Closed
elgg-gitbot opened this issue Feb 16, 2013 · 21 comments
Closed

add admin menu button for refresh cache (Trac #2111) #2111

elgg-gitbot opened this issue Feb 16, 2013 · 21 comments

Comments

@elgg-gitbot
Copy link

Original ticket http://trac.elgg.org/ticket/2111 on 40318879-11-30 by cash, assigned to cash.

Elgg version: 1.7

As a plugin author, I frequently have to give detailed instructions on how to refresh the cache (change plugin order, turn plugin off and then on) when upgrading a plugin.

A button added to the Admin sidebar menu that refreshes the cache solves this.

@elgg-gitbot
Copy link
Author

Milestone changed to Elgg 1.8 by cash on 40401194-09-05

@elgg-gitbot
Copy link
Author

Milestone changed to Elgg 1.8.1 by cash on 40897955-02-09

@elgg-gitbot
Copy link
Author

cash wrote on 41239720-03-06

Brett, Evan, and Mayank:

Thoughts on where to put this button in the new admin area? As a button in sidebar or should it get its own page (seems like overkill but so far all sidebar menu items lead to a page)?

@elgg-gitbot
Copy link
Author

brettp wrote on 41239740-08-02

Somewhere on the settings/advanced page? I don't think it needs to be as prominent to be on every page of the admin area.

@elgg-gitbot
Copy link
Author

ewinslow wrote on 41240190-09-10

Other option I thought of is dashboard page. I agree that putting it on every page might be overkill.

@elgg-gitbot
Copy link
Author

trac user mayanks43 wrote on 41240678-08-09

Why not put it as a link beside the activate all and deactivate all links in the plugins advanced menu?

@elgg-gitbot
Copy link
Author

cash wrote on 41243343-10-15

Okay, three options:

  • settings pages (I'd do both if we choose this)
  • as a common tasks widget on the dashboard (or as a button opposite of the add widget button)
  • as a link on the advanced plugins page

I like settings page as that is where a user goes to turn caching on/off.

Other thoughts?

@elgg-gitbot
Copy link
Author

anirupdutta wrote on 41243409-09-13

well when in development I think its necessary to have a reset cache button at the sidebar.works fine say if you are working on a theme and you forgot to switch off the cache,then a button at the sidebar helps.We can easily have a choice at the plugin settings whether to have it at the sidebar or not.Gives flexibility.Second in the modified version of the developers plugin I wrote,I registered a new admin menu called reset cache along with a tab with little bit of documentation.So plugin authors won't have to write about it and also eases the process of administration for new Elgg admins.
project link [https://github.com/anirupdutta/Develor-Tools]
extremely sorry for the spelling mistake.was in a hurry so didn't notice it.

@elgg-gitbot
Copy link
Author

ewinslow wrote on 41244769-02-11

You may have a point with your suggested use case but I am most definitely against having a configuration option for this.

@elgg-gitbot
Copy link
Author

Attachment added by trac user mayanks43 on 41249327-06-23: reset_cache.patch

@elgg-gitbot
Copy link
Author

trac user mayanks43 wrote on 41249339-11-13

Sorry for multiple attachments.... some problem on my network side....
Anyways I added the button to the sidebar. Reviews please.

@elgg-gitbot
Copy link
Author

trac user mayanks43 wrote on 41249352-07-28

Kindly delete the unnecessary attachments if possible....

@elgg-gitbot
Copy link
Author

brettp wrote on 41250221-02-05

Thanks for the patch!

The functionality looks good. There are a few issues:

  • Please check that you're following the [http://trac.elgg.org/browser/elgg/trunk/CODING.txt coding standards](You can upload individual files to http://sniff.elgg.org/ to check compliance.)
  • I'm not a fan of the location on the menu. Can we move it to the settings pages? Other thoughts on that?

@elgg-gitbot
Copy link
Author

cash wrote on 41250507-09-10

The use case for this is as follows:

  • a new version of a plugin is installed and something is wrong because of new views that have been added
  • something is not quite working with the site and the admin wants to do something and doesn't know what
  • something went wrong when the views were cached last and people are getting empty css files

Right now the conventional wisdom in the forums is to hit the upgrade script and hope for the best. This button gives me an outlet. I think putting it on both of the settings pages is a good idea. Maybe in the future we will have a control panel widget with buttons for reseting cache, running an upgrade, switching the site into developer mode.

@elgg-gitbot
Copy link
Author

brettp wrote on 41299585-10-02

Let's get this in core before the patch gets too far out of sync. We'll want to move it to the settings pages.
mayanks43 - Is this in github anywhere or just as a patch?

@elgg-gitbot
Copy link
Author

Milestone changed to Elgg 1.8 by brettp on 41299585-10-02

@elgg-gitbot
Copy link
Author

trac user mayanks43 wrote on 41299590-08-31

This is just a patch...

@elgg-gitbot
Copy link
Author

Milestone changed to Elgg 1.8.1 by cash on 41383044-04-15

@elgg-gitbot
Copy link
Author

trac user Purus wrote on 41732099-06-13

I feel that this button shold be in the Plugins page of Admin section where all the plugins are listed. This gives an easy access to that for a developer.

@elgg-gitbot
Copy link
Author

Milestone changed to Elgg 1.8.2 by cash on 41770036-09-01

@elgg-gitbot
Copy link
Author

cash wrote on 41938626-12-09

Fixes #4185, #2111 adds control panel widget
Changeset: 1ec7692

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant