Opened 3 years ago
Closed 13 months ago
#2162 closed Defect (fixed)
Make group entities display correctly without groups plugin enabled
| Reported by: | brettp | Owned by: | |
|---|---|---|---|
| Priority: | low | Milestone: | Elgg 1.8.4 |
| Component: | Core | Version: | 1.8 Beta |
| Severity: | minor | Keywords: | |
| Cc: | brettp | Difficulty: | moderate |
Description
Elgg's extensible architecture means there is no reason to use is_plugin_enabled() in logic anywhere in core to determine output or behavior.
Change History (10)
comment:1 Changed 3 years ago by brettp
- Priority changed from high to low
- Severity changed from major to annoying
comment:2 Changed 3 years ago by brettp
- Difficulty set to easy
comment:3 Changed 2 years ago by cash
- admin/overview/online view
- admin/users/online view
- admin/users/newest view
- input_livesearch_page_handler()
- thewire has some that can be pulled out
- sitepages has a reference to riverdashboard that can probably be removed
comment:4 Changed 2 years ago by cash
- Resolution set to fixed
- Status changed from new to closed
I think these have all been removed. Reopen or create new ticket if any are found.
comment:5 Changed 23 months ago by ewinslow
- Resolution fixed deleted
- Status changed from closed to reopened
Livesearch handler in engine/lib/input.php:311-314
// don't return results if groups aren't enabled.
if (!elgg_is_active_plugin('groups')) {
continue;
}
comment:6 Changed 23 months ago by ewinslow
Also see #3689
comment:7 Changed 23 months ago by brettp
Groups is a problem because it's a top level type but the UI layer is wrapped in a plugin. We solved a similar problem with users / profile for 1.8 by adding to core the basics for users to display without the profile plugin. We could use a similar approach for groups.
comment:8 Changed 21 months ago by brettp
- Difficulty changed from easy to moderate
- Milestone changed from Elgg 1.8.0 to Elgg 1.8.x
- Severity changed from annoying to minor
- Summary changed from Remove is_plugin_enabled() tests from core. to Make group entities display correctly without groups plugin enabled
comment:9 Changed 16 months ago by cash
- Milestone changed from Elgg 1.8.x to Elgg 1.8.4
- Status changed from reopened to new
comment:10 Changed 13 months ago by brettp
- Resolution set to fixed
- Status changed from new to closed
This looks like it was fixed at some point.

There are only a few of these left in core itself. Core plugins (especially the tabbed profile) have tons of them.