Opened 3 years ago
Closed 3 years ago
#2195 closed Enhancement (fixed)
add option to use a different pageshell
| Reported by: | cash | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | Elgg 1.8.0 |
| Component: | Core | Version: | 1.7 |
| Severity: | minor | Keywords: | |
| Cc: | brettp, asa.denton@… | Difficulty: |
Description
The current page_draw() function has these arguments:
page_draw($title, $body, $sidebar = "")
Sidebar is handled through layouts rather than page_draw so that can be removed. It would also be great if we could specify a different pageshell from the default. For example, I may not want the normal header on a particular page.
Change History (5)
comment:1 Changed 3 years ago by brettp
comment:2 Changed 3 years ago by adenton
- Cc asa.denton@… added
Hi Guys,
I was thinking that the sidebar parameter is far too restrictive. I would change that to the $vars array. I am going to submit a change along the lines of that. There is nothing stopping people passing $sidebar in through the array but it would be much more useful to have additional parameters, especially if people want to vary pageshells.
Asa
comment:3 Changed 3 years ago by brettp
A similar change was made in [svn:6602] to allow pageshell, but I'm for removing removing the sidebar option. If we remove the sidebar option, we could go ahead and add $vars as a 4th optional argument:
function page_draw($title, $body, $page_shell = 'page_shells/default', $vars = array())
comment:4 Changed 3 years ago by cash
See also #2349
comment:5 Changed 3 years ago by brettp
- Resolution set to fixed
- Status changed from new to closed
(In [svn:6704]) Fixes #2195. 3rd and 4th params of page_draw() are now $page_shell and $vars.

heh I have an uncommitted change that does exactly this. Was waiting to commit until I could check if nothing was trying to use $sidebar.