We have moved to Github. Please open tickets there.

Opened 3 years ago

Closed 3 years ago

#2306 closed Defect (fixed)

Deprecate get/count_user_objects() in favor of elgg_get_entities

Reported by: adenton Owned by: ewinslow
Priority: normal Milestone: Elgg 1.8.0
Component: Core Version: 1.7
Severity: minor Keywords:
Cc: brettp Difficulty: trivial

Description

This should not use both. According to the definition in ​http://docs.elgg.org/wiki/Engine/DataModel/Containers it should just use container_guid. This would make sense when having entities related to a user but owned/authored by someone else.

Change History (5)

comment:1 Changed 3 years ago by brettp

  • Difficulty set to trivial
  • Summary changed from get_user_objects uses both owner_guid and container_guid to get_user_objects() should use only owner_guid.

It should just use own_guid. users aren't usually used as containers for entities owned by other users. A relationship would be better in this case.

comment:2 Changed 3 years ago by adenton

I just spotted the same issue in count_user_objects. These obviously need to match. Just want to make sure it is not missed.

comment:3 Changed 3 years ago by ewinslow

  • Owner set to ewinslow
  • Status changed from new to assigned

Shouldn't this just be deprecated in favor of elgg_get_entities?

comment:4 Changed 3 years ago by ewinslow

  • Summary changed from get_user_objects() should use only owner_guid. to Deprecate get/count_user_objects() in favor of elgg_get_entities

comment:5 Changed 3 years ago by ewinslow

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [svn:7286]) Fixes #2306: deprecated get/count/list_user_objects as well as get_user_objects_by_metadata

Note: See TracTickets for help on using tickets.