Opened 3 years ago
Closed 2 years ago
#2317 closed Enhancement (fixed)
Make css view more granular
| Reported by: | ewinslow | Owned by: | cash |
|---|---|---|---|
| Priority: | low | Milestone: | Elgg 1.8.0 |
| Component: | Core | Version: | 1.7 |
| Severity: | trivial | Keywords: | |
| Cc: | brettp, ewinslow | Difficulty: | easy |
Description
This would allow greater control for plugins to override only certain aspects of the CSS. Also, helps to keep things organized.
e.g.
- css.php
- css/reset.php
- css/base.php
- css/layout.php
- css/spotlight.php
- css/footer.php
- css/topbar.php
- css/tools.php
- css/messages.php
- css/collapsable.php
- css/forms.php
- css/accounts.php
- css/profile.php
- css/river.php
- css/listings.php
- css/friends.php
- css/admin.php
- css/comments.php
- css/ownerblock.php
- css/pagination.php
- css/collections.php
- css/friendpicker.php
- css/widgets.php
- css/breadcrumbs.php
- css/misc.php
- css/settings.php
- css/autocomplete.php
Change History (12)
comment:1 Changed 3 years ago by cash
- Milestone changed from Elgg 1.7.2 to Elgg 1.8
comment:2 Changed 3 years ago by ewinslow
It could be done in a way that is 100% backwards compatible: css.php echoes each one of these views. If css.php is overriden, then none of them are included. No problem.
comment:3 Changed 3 years ago by brettp
- Difficulty set to easy
- Priority changed from normal to low
- Severity changed from minor to trivial
Is there a good use case for someone wanting to only override one of these views? If not I don't think it's something that needs implemented in core right now.
comment:4 Changed 3 years ago by ewinslow
I guess I'm envisioning themes that make very simple, atomic changes like:
- making the layout fluid width instead of fixed width
- moving the sidebar to the right instead of the left
- changing only the base fonts/styles
A site then would mix/match the themes to get to look they want. Perhaps there is a better way to implement this, though.
comment:5 Changed 2 years ago by cash
- Owner set to cash
- Status changed from new to assigned
comment:6 Changed 2 years ago by ewinslow
I'm no longer a fan of the divisions that I originally suggested -- perhaps it would be good to work on the CSS Framework first, then revisit this?
comment:7 Changed 2 years ago by cash
I pulled a few things out as an experiment. I'll commit for feedback and we can we always change it.
comment:8 Changed 2 years ago by cash
(In [svn:7491]) Refs #2317 pulled a few sections of CSS out to try out granular CSS
comment:9 Changed 2 years ago by cash
(In [svn:7574]) Refs #2317 pulled more css out into sub views
comment:10 Changed 2 years ago by cash
(In [svn:7593]) Refs #2317 starting create a css skin sub view
comment:11 Changed 2 years ago by cash
(In [svn:7807]) Refs #2317 dividing css element views into skin views and base views. The expectation is that the base views would not be overridden in a theme so the admin css can depend on them.
comment:12 Changed 2 years ago by cash
- Resolution set to fixed
- Status changed from assigned to closed
I'm closing this as it is done. We are just making refinements now.
Moving milestone to 1.8.
I expect that most themes override the entire CSS view which would mean overriding every single one of these views. That seems unnecessary. I appreciate the division into sections, but themes have the option of doing that if desired right now. I'm just having a hard time seeing anything compelling here.