Put core pages under a "pages" directory

[ewinslow]

Several directories in core hold standalone pages. These could be placed under a "pages" directory to match the convention of "actions" and "views" and to section off top-level core files to make things feel simpler.

[cash]

Evan, you're a genius! (our install is already organized that way ;-)

I got very tired of introducing new developers to Elgg by saying all the core action controllers are in the actions directory and the core page controllers are spread over several directories. It was easy to change this - especially now that all the pages go through the page handling system.

[ewinslow]

Perhaps we should do the same for the core plugins too?

[brettp]

Agreed. I quite like Cash's method of using the page handler to include pages with the pages/ dir (as long as the pages/*.php files don't include engine/start.php and so cannot be accessed directly). I think it's great standard to adopt in core and bundled plugins.

[ewinslow]

Completely yanking files could be a bummer for those who relied on the direct access "feature." What is the best way to go about deprecating direct access? Some custom .htaccess rules perhaps?

Also, wanted to clarify what would go under "pages":

• account
• admin
• dashboard
• entities
• friends (except for pickercallback.php)
• search
• settings

2. Should pickercallback.php go somewhere else or stay where it is?

[cash]

search goes away I believe. The core stopped using it in 1.7. The rest of your list looks correct.

Should pickercallback be turned into an action - will that be the standard for Ajax callbacks?

[cash]

(In [svn:6984]) Refs #2344 - move account pages into pages directory

[cash]

(In [svn:6985]) Refs #2344 - moves dashboard pages into pages directory

[cash]

(In [svn:6986]) Refs #2344 - moves settings pages into the pages directory

[cash]

(In [svn:6987]) Refs #2344 - removed unused search and admin directories

[cash]

(In [svn:6988]) Refs #2344 - moves entities directory to pages directory

[cash]

(In [svn:6989]) Closes #2344 - moves friends pages into pages directory