Opened 3 years ago
Closed 3 years ago
#2366 closed Task (fixed)
functions is_ip_in_array() and test_ip() can be deprecated
| Reported by: | cash | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | Elgg 1.8.0 |
| Component: | Core | Version: | 1.7 |
| Severity: | minor | Keywords: | |
| Cc: | brettp | Difficulty: |
Description
The 2 functions are in elgglib.php and are not used anywhere. One of them has questionable provenance which could be a licensing issue.
Change History (3)
comment:1 Changed 3 years ago by dave
comment:2 Changed 3 years ago by brettp
(In [svn:6935]) Refs #2366: Merged previous to 1.7 branch.
comment:3 Changed 3 years ago by brettp
- Resolution set to fixed
- Status changed from new to closed
Fixed in [svn:6934].
Note: See
TracTickets for help on using
tickets.
If test_ip() is not being used anywhere then it should be removed immediately. Searching the web, I can't find any license associated with the function so it should never have been included in core, that was a mistake.
As a reminder to myself, as Elgg is available under both MIT and GPL v2 - we will also need to replace the autop()function in output.php as it comes from WordPress so is not compatible with the MIT license. This is why the MIT version is not available for download from elgg.org yet.