Insufficient error checking in getContainer() (objects.php)

[StanD]

Function getContainer() (called from getContainerEntity()) does a simple "return":

function getContainer() {

return $this->get('container_guid');

}

As a result, if the container_guid is not set, the results are unpredictable - and getContainerEntity() causes PHP to crash. This comes up when running getContainerEntity() on a list of entities that includes ElggUser and ElggGroup object... PHP definitely goes kaboom.

It'd be better if getContainer did a rudimentary check and returned false (or null) if the container_guid was not found.

[cash]

The issue is that the Container methods only exist for the ElggObject class. Ticket #2134 is about adding the methods to the ElggEntity class which would fix this problem. Until then, the plugin causing this problem needs to do a check for class type before calling the container methods.

[ewinslow]

Fixed in [svn:7219]