confusion b/w clearfloat and clearfix

[ewinslow]

This may be bordering on bikeshedding... and if it is feel free to close this ticket, but:

I think we should rename the Elgg 1.8 "clearfloat" to "clearfix" and bring back .clearfloat { clear:both; } for three reasons:

1. "clearfix" is the commonly accepted class name for the technique Elgg currently achieves using the class name "clearfloat"
2. "clearfloat" is commonly associated with the technique Elgg used to have.
3. Why introduce yet another point of backwards incompatibility with themes when there seems to be no good reason to?

As my proof for points 1 and 2 I offer you the google search results for ​clearfloat and ​clearfix.

[cash]

Evan is exactly right. Using terms differently from the rest of the world and breaking themes and plugins unnecessarily are a bad ideas.

Fixing this will break all the themes and plugins on elgg.com - how do we handle this?

[brettp]

Replying to cash:

Fixing this will break all the themes and plugins on elgg.com - how do we handle this?

Don't worry about it. It's an easy enough fix to make on our side.

[ewinslow]

(In [svn:7223]) Fixes #2440: Converted clearfloat to clearfix, brought back orig clearfloat

[cash]

The group profile page is now broken - a clear float change is probably the culprit.

[cash]

To be specific, the activity box is jumping up into the group profile fields on Firefox

[cash]

Hmmm...cannot reproduce now. Closing this.