We have moved to Github. Please open tickets there.

Opened 3 years ago

Closed 3 years ago

#2455 closed Defect (wontfix)

Consider changing SET NAMES utf8 to mysql_set_charset(utf8)

Reported by: brettp Owned by:
Priority: normal Milestone: Elgg 1.8.0
Component: Core Version: 1.8 Beta
Severity: minor Keywords:
Cc: brettp Difficulty:

Description

The PHP docs say using SET NAMES isn't recommended, but doesn't say why.

See ​http://php.net/manual/en/function.mysql-set-charset.php.

Change History (2)

comment:1 Changed 3 years ago by cash

If I remember correctly, SET NAMES was the old way of doing this before the mysql_set_charset function existed. Elgg would need to bump up its required version of PHP to use this function.

comment:2 Changed 3 years ago by brettp

  • Resolution set to wontfix
  • Status changed from new to closed

Good point. Let's not worry about this then so we can keep the reqs low.

Note: See TracTickets for help on using tickets.