Opened 3 years ago
Closed 9 months ago
#2543 closed Enhancement (fixed)
Use underscores in function and variable names
| Reported by: | brettp | Owned by: | |
|---|---|---|---|
| Priority: | low | Milestone: | Elgg 1.8.0 |
| Component: | Core | Version: | Github Master |
| Severity: | annoying | Keywords: | |
| Cc: | brettp | Difficulty: | moderate |
Description (last modified by ewinslow)
In procedural code, if there's a word break, use an underscore.
- isloggedin()
- isadminloggedin()
- get_loggedin_userid()
Probably tons others that my brain has blocked. I'll never get back the 2 seconds I lose each time I look at one of these jumbles of characters and think "Huh?"
Change History (9)
comment:1 follow-up: ↓ 2 Changed 2 years ago by ewinslow
comment:3 Changed 2 years ago by cash
- Milestone changed from Elgg 1.8 to Elgg 1.9
comment:4 Changed 2 years ago by brettp
- Difficulty changed from easy to moderate
- Summary changed from Use underscores in function names to Use underscores in function and variable names
Set to moderate because of the annoyance factor.
comment:5 Changed 2 years ago by brettp
(In [svn:7725]) Refs #2543: set_default_config() uses better names. get_config() rewrites old names to new, but have to double up assignments in $CONFIG for ppl not using get_config().
comment:6 Changed 2 years ago by brettp
See [svn:8077].
comment:7 Changed 2 years ago by brettp
(In [svn:8078]) Refs #2543: Core uses the new functions from previous commit.
comment:8 Changed 2 years ago by brettp
(In [svn:8079]) Refs #2543: Updated trunk mods and views to use the new functions from previous 2 commits.
comment:9 Changed 9 months ago by ewinslow
- Description modified (diff)
- Milestone changed from Near Term Future Release to Elgg 1.8.0
- Resolution set to fixed
- Status changed from new to closed
Calling this accomplished. Can open new tickets as particular instances arise.
So are we going for something like:
?