#2557 closed Defect (fixed)
move groups register_entity call to the groups plugin
| Reported by: | coldtrick | Owned by: | |
|---|---|---|---|
| Priority: | low | Milestone: | Elgg 1.7.7 |
| Component: | Core | Version: | 1.7 |
| Severity: | trivial | Keywords: | |
| Cc: | brettp | Difficulty: |
Description
There will be sites based on Elgg that won't use groups (the plugin). Even if groups is disabled a lot of group functions will still be loaded/parsed as they exist in engine/lib/groups.php.
Shouldn't the lib be moved to the plugin, so it is only loaded if the plugin is enabled?
This question came to mind because the group entity search option was visible on the search results page without the groups enabled. I would not like to see the groups search option when groups is not on.
Change History (7)
comment:1 Changed 3 years ago by cash
comment:2 Changed 3 years ago by cash
- Resolution set to wontfix
- Status changed from new to closed
#2403 is fixed.
If a developer wanted to implement their own groups plugin, they shouldn't need to copy this core code out of the original plugin into theirs. It should remain a core library.
comment:3 Changed 3 years ago by coldtrick
Ok, no problem there. The only thing that i don't agree with is that the init still remains in core. This should be handled by the plugin. This will also solve the issue with the searchable entity being visible even if groups is disabled.
comment:4 Changed 3 years ago by cash
- Resolution wontfix deleted
- Status changed from closed to reopened
- Summary changed from Remove group lib from core functions to move groups register_entity call to the groups plugin
That's a possibility - will think more on it
comment:5 Changed 2 years ago by cash
- Milestone changed from Needs Review to Elgg 1.7.7
comment:6 Changed 2 years ago by cash
- Resolution set to fixed
- Status changed from reopened to closed
(In [svn:7833]) Fixes #2557 moves register_entity call on groups to groups plugin
comment:7 Changed 2 years ago by cash
(In [svn:7916]) Refs #2557 merged fix into trunk from 1.7 branch
When #2403 is fixed, you will be able to remove groups from the search sidebar.