We have moved to Github. Please open tickets there.

Opened 3 years ago

Closed 2 years ago

#2561 closed Defect (fixed)

join_group triggers join event even if join fails

Reported by: coldtrick Owned by:
Priority: normal Milestone: Elgg 1.8.0
Component: Core Version: 1.7
Severity: minor Keywords:
Cc: brettp Difficulty: trivial

Description

file: engine/lib/groups.php
function: join_group

this function always triggers the join event. This should only happen if $result = true;

Change History (7)

comment:1 Changed 3 years ago by brettp

  • Difficulty set to trivial
  • Milestone changed from Needs Review to Elgg 1.7.4

Same for leave_group()

comment:2 Changed 3 years ago by brettp

  • Milestone changed from Elgg 1.7.4 to Elgg 1.8

comment:3 Changed 3 years ago by ewinslow

  • Owner set to ewinslow
  • Status changed from new to assigned

comment:4 Changed 3 years ago by cash

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [svn:7303]) Fixes #2561 fixed typo - thanks for the report

comment:5 Changed 3 years ago by cash

  • Resolution fixed deleted
  • Status changed from closed to reopened

Grrrr....closed the wrong ticket

comment:6 Changed 2 years ago by ewinslow

  • Owner ewinslow deleted
  • Status changed from reopened to new

comment:7 Changed 2 years ago by cash

  • Resolution set to fixed
  • Status changed from new to closed

(In [svn:7799]) Fixes #2561 only triggering join, group event if the add relationship succeeded

Note: See TracTickets for help on using tickets.