#2619 closed Defect (duplicate)
get_entity_icon_url() && elgg_normalize_url() not working together nicely
| Reported by: | jtilson | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | Elgg 1.8.0 |
| Component: | Core | Version: | Github Master |
| Severity: | critical | Keywords: | |
| Cc: | brettp | Difficulty: |
Description
Just SVN updated my elgg trunk install and suddenly user icons are no longer appearing. I checked this out and the problem seems to lay in the elgg_normalize_url() function. Specifically it's not processing the url it was passed by the get_entity_icon_url() function.
The result of elgg_get_entity_icon_url() now looks like this:
http://mod/profile/icondirect.php?lastcache=1288894068&joindate=1273522320&guid=2&size=topbar
I confirmed this error on a clean setup as well.
To reproduce:
- Setup an Elgg site with latest code from the trunk
- Set a user avatar
- User avatar/icons no longer display
Change History (7)
comment:1 Changed 3 years ago by brettp
- Resolution set to duplicate
- Status changed from new to closed
comment:2 Changed 3 years ago by brettp
- Milestone changed from Needs Review to Elgg 1.8
comment:3 Changed 3 years ago by cash
I've had problems with elgg_normalize_url() on other fronts. I tried to use it for javascript files and the regex was choking on the '.' so it probably doesn't like '?' or '&' either.
comment:4 Changed 3 years ago by brettp
@Cash - Can you post the URL? I'm going to write some unit tests for it.
comment:5 Changed 3 years ago by jtilson
@Brett (if you didn't do this already) you can test with: mod/profile/icondirect.php?lastcache=1288894068&joindate=1273522320&guid=2&size=topbar
comment:6 Changed 3 years ago by cash
Pass in: "vendors/jquery/jquery-1.4.2.min.js"
Should get out: elgg_get_site_url() . "vendors/jquery/jquery-1.4.2.min.js"
comment:7 Changed 3 years ago by jtilson
Here's another one:
"mod/tidypics/graphics/image_error_small.png"
Dupe #2463