We have moved to Github. Please open tickets there.

Opened 3 years ago

Closed 16 months ago

Last modified 12 months ago

#2625 closed Enhancement (fixed)

elgg_view_annotation() has unnecessary code to check for annotation name

Reported by: cash Owned by:
Priority: low Milestone: Elgg 1.8.4
Component: Core Version: 1.7
Severity: annoying Keywords:
Cc: brettp Difficulty: trivial

Description

Looks like there might have been a bug at some point in loading annotations from the database and they worked around it with this hack.

	$name = $annotation->name;
	$intname = (int) $name;
	if ("{$intname}" == "{$name}") {
		$name = get_metastring($intname);
	}

Change History (4)

comment:1 Changed 3 years ago by cash

  • Milestone changed from Elgg 1.8 to Elgg 1.8.1

comment:2 Changed 16 months ago by cash

  • Milestone changed from Elgg 1.8.x to Elgg 1.8.4

comment:3 Changed 16 months ago by Cash Costello

  • Resolution set to fixed
  • Status changed from new to closed

Fixes #2625 removed old hack from elgg_view_annotation()

Changeset: efb6ba4d0ab857703d721c5538150cf2a337347d

comment:4 Changed 12 months ago by Cash Costello

Fixes #2625 removed old hack from elgg_view_annotation()

Changeset: efb6ba4d0ab857703d721c5538150cf2a337347d

Note: See TracTickets for help on using tickets.