ElggEntity::addRelationship() might be backwards
|Reported by:||brettp||Owned by:|
|Priority:||normal||Milestone:||Near Term Future Release|
ElggEntity::addRelationship($guid, $relationship) claims you should read the relationship as "$guid is a $relationship of this entity" but it calls add_entity_relationship($this->guid, $relationship, $guid) which says to read the relationship as "$guid_one is a $relationship of $guid_two."
Which is it? I lean toward add_entity_relationship()'s description as feeling more natural.
For what it's worth, addRelationship() isn't called anywhere in core. (And yes, I'm aware I wrote the docs for both of these functions...)