We have moved to Github. Please open tickets there.

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#2823 closed Defect (fixed)

plugin conflicts should not allow conflicting plugins to be enabled.

Reported by: cash Owned by:
Priority: normal Milestone: Elgg 1.8.0
Component: Core Version: Github Master
Severity: minor Keywords:
Cc: brett@… Difficulty:

Description

Sorry that I cannot be more specific but don't have time at the moment to debug this.

Put both the profile and tabbed_profile plugins on the same install. Add this to the manifest of the tabbed_profile:

	<conflicts>
		<type>plugin</type>
		<name>profile</name>
		<version>1.8</version>
	</conflicts>

Deactivate the profile plugin and the active the tabbed_profile plugin. Elgg throws a exception when it tries to load the plugin.

Change History (4)

comment:1 Changed 2 years ago by brettp

(In [svn:8009]) Refs #2823: Fixed typo that was causing WSOD in tabbed profile.

comment:2 Changed 2 years ago by brettp

  • Summary changed from plugin conflicts code has a bug to plugin conflicts should not allow conflicting plugins to be enabled.

@Cash - There was a call to an undefined function in tabbed_profile/start.php. I fixed that, and now enabling works, but there is a bug in that the profile can be enabled even if tabbed profile is already enabled.

comment:3 Changed 2 years ago by brettp

  • Resolution set to fixed
  • Status changed from new to closed

(In [svn:8010]) Fixes #2820, Fixes #2823. Using elgg_get_plugins() in elgg_get_plugins_provides(). Fixed plugin conflicts system. Removed cruft from ElggPluginPackage. Fixed deprecated get_installed_plugins() to honor the type requested.

comment:4 Changed 2 years ago by brettp

I should say that I never saw this throw an exception, only WSOD. If you can duplicate it with the new code, please reopen.

Note: See TracTickets for help on using tickets.