We have moved to Github. Please open tickets there.

Opened 2 years ago

Closed 2 years ago

#2888 closed Defect (fixed)

Plugin system dies if plugin manually deleted

Reported by: ewinslow Owned by: brettp
Priority: normal Milestone: Elgg 1.8.0
Component: Core Version: Github Master
Severity: minor Keywords:
Cc: brett@… Difficulty:

Description

As opposed to just deactivating the plugin.

ElggPluginPackage line 321 says PHP.

Change History (6)

comment:1 Changed 2 years ago by brettp

  • Version changed from 1.7 to SVN Trunk

Does it say anything else about the error? I can't duplicate this. See #2821 for a related ticket.

comment:2 Changed 2 years ago by ewinslow

Here's what happened:

  1. Delete plugin
  2. Upgrade to latest SVN
  3. SVN dies, comment out line 321
  4. Refresh, get error message about plugin being invalid -> plugin disabled
  5. Uncomment line 321
  6. Refresh, back to normal

So in this case #2 might have something to do with the problem not being reproducible

comment:3 Changed 2 years ago by cash

  • Milestone changed from Needs Review to Elgg 1.8

I can reproduce:

  1. active plugin
  2. delete plugin from disk
  3. get error

Fatal error: Call to a member function getConflicts() on a non-object in /var/www/engine/classes/ElggPluginPackage.php on line 321

comment:4 Changed 2 years ago by brettp

Finally duplicated. This has to be a plugin that declares admin_interface = simple.

comment:5 Changed 2 years ago by brettp

  • Owner set to brettp
  • Status changed from new to assigned

comment:6 Changed 2 years ago by brettp

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [svn:8121]) Fixes #2888: Plugins are checked for validity in elgg_get_plugins(). It won't return broken plugins unless specifically requested.

Note: See TracTickets for help on using tickets.