We have moved to Github. Please open tickets there.

Opened 2 years ago

Closed 2 years ago

#2902 closed Enhancement (fixed)

elgg-toggler pattern should use class, not id

Reported by: ewinslow Owned by:
Priority: normal Milestone: Elgg 1.8.0
Component: Core Version: Github Master
Severity: minor Keywords:
Cc: brett@… Difficulty:

Description 

<a class="elgg-toggler elgg-toggles-$id_of_togglee">Click me!</a>

<div class="hidden" id="$id_of_togglee"></div>

Because I may want more than one element on the page to be able to toggle some other element (for example, one to open, one to close).

Also, the id of the togglee should not require an "elgg-togglee-" prefix, just a good, semantic id, since that id could presumably be used for things other than toggling.

Change History (2)

comment:1 Changed 2 years ago by ewinslow

  • Milestone changed from Needs Review to Elgg 1.8
  • Type changed from Defect to Enhancement
  • Version changed from 1.7 to SVN Trunk

comment:2 Changed 2 years ago by ewinslow

  • Resolution set to fixed
  • Status changed from new to closed

(In [svn:8228]) Fixes #2902: Added elgg-toggler pattern.

Note: See TracTickets for help on using tickets.