We have moved to Github. Please open tickets there.

Opened 2 years ago

Closed 21 months ago

#2911 closed Enhancement (fixed)

Use new menu system for embed tabs

Reported by: cash Owned by:
Priority: normal Milestone: Elgg 1.8.0
Component: Embed Version: Github Master
Severity: minor Keywords:
Cc: brett@… Difficulty: moderate

Description

When you click a file, the lightbox closes but nothing is inserted.

  1. Looks like it was hacked to add support for ecml
  2. It started out life as a hack
  3. It has a hacked lightbox

I like the plugin hook so that other plugins can add sections. I'm wondering

Change History (9)

comment:1 Changed 2 years ago by brettp

I'm left wondering, too.... ;)

comment:2 Changed 2 years ago by cash

  • Difficulty set to difficult
  • Priority changed from normal to high

To do this right is probably difficult. Need to update to new lightbox and look into the dependencies created between ecml and this. Also have to look at the special code added to the file plugin for saving.

comment:3 Changed 2 years ago by cash

  • Milestone changed from Elgg 1.8.0 to Elgg 1.8 Beta 2

look at patch from #3360

comment:4 Changed 2 years ago by cash

(In [svn:9135]) Refs #3360 #2911 applying ashleyward's patch for embed plugin - thanks!

comment:5 Changed 2 years ago by cash

  • Difficulty changed from difficult to moderate
  • Severity changed from major to minor
  • Summary changed from Embed plugin does not work to Improve embed plugin

I'd like to use the built-in lightbox for this. This may be post 1.8b2 but pre 1.8.0 release work.

If we wanted to make it semi-presentable, it needs work with:

  • lightbox
  • css
  • javascript

comment:6 Changed 2 years ago by brettp

  • Owner set to brettp
  • Status changed from new to assigned

I'll look into migrating to the bundled lightbox for b2.

comment:7 Changed 2 years ago by cash

  • Milestone changed from Elgg 1.8 Beta 2 to Elgg 1.8.0
  • Summary changed from Improve embed plugin to Improve embed core plugin (php and javascript)

Using the bundled lightbox + fixing the CSS will be another ticket: #3564

comment:8 Changed 2 years ago by cash

  • Owner brettp deleted
  • Priority changed from high to normal
  • Status changed from assigned to new
  • Summary changed from Improve embed core plugin (php and javascript) to Use new menu system for embed tabs
  • Type changed from Defect to Enhancement

comment:9 Changed 21 months ago by Brett Profitt

  • Resolution set to fixed
  • Status changed from new to closed

Fixes #2911. Embed plugins works again. Added menu for embed sections. This plugin is painfully messy.

Changeset: 146c55ddd745be06f6206e70884cb9e430ba6231

Note: See TracTickets for help on using tickets.