We have moved to Github. Please open tickets there.

Opened 2 years ago

Closed 2 years ago

#2934 closed Enhancement (fixed)

css/screen media query confusion

Reported by: ewinslow Owned by:
Priority: normal Milestone: Elgg 1.8.0
Component: Core Version: Github Master
Severity: minor Keywords:
Cc: brett@… Difficulty: trivial

Description

There is a css media type named "screen" which is distinct from "print", however I don't think that's the distinction we're trying to make with css/screen. Is css/screen too confusing? Perhaps css/main? css/elgg?

Change History (4)

comment:1 Changed 2 years ago by ewinslow

  • Version changed from 1.8 to SVN Trunk

comment:2 Changed 2 years ago by cash

Actually, that was the distinction I was trying to make. Was planning on create a plain vanilla css/print view. Bad idea?

comment:3 Changed 2 years ago by ewinslow

Ah, I see. Didn't realize that!

In this case I definitely would argue that that harnessing viewtype is a better idea for displaying print-friendly pages. In that case you'd have views/print/css/screen.php. That's where I anticipated the confusion coming in.

comment:4 Changed 2 years ago by cash

  • Resolution set to fixed
  • Status changed from new to closed

(In [svn:8383]) Fixes #2934 switching to css/elgg for css view since using a print viewtype is a good idea and screen would become a confusing idea

Note: See TracTickets for help on using tickets.