Remove inline javascript

[brettp]

All javascript should be encapsulated in the elgg JS object.

[cash]

Should it all be in the elgg JS object by way of extending elgg.js or should some of it be in separate scripts/views that are only included on the appropriate pages? When do we extend the main elgg js view and when do we use a separate script?

[brettp]

Before diving in, let's establish policies for Cash's questions about when to extend and when to register. My initial reaction is that JS potentially used on every page should extend js/elgg and add its own named spaced object to the elgg object, while JS required only for some pages (like the slidy friends picker or the pages submenu children tree thing) should use elgg_register_js().

[ewinslow]

(In [svn:8711]) Refs #3016: Removes inline javascript from embed, file, groups, messages, profile, thewire

[ewinslow]

(In [svn:8712]) Refs #3016: Why didn't you make it in last commit?

[cash]

(In [svn:8812]) Refs #3016 making the final elgg.js more readable

[ewinslow]

I've lost motivation to do this for 1.8. Based on my scan, it looks like collections, the friendspicker, walled garden, and image cropping are the biggest offenders. If they're not broken, we can refactor later. If they're broken, we can bump the milestone again...

[cash]

I believe we have completed this. Any other individual problems can be their own tickets.