We have moved to Github. Please open tickets there.

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#3094 closed Defect (fixed)

Clicking outside of a popup should close the popup

Reported by: brettp Owned by:
Priority: normal Milestone: Elgg 1.8 Beta
Component: UI/UX Version: Github Master
Severity: annoying Keywords:
Cc: brett@… Difficulty: easy

Description

It seems weird that it doesn't.

Change History (8)

comment:1 Changed 2 years ago by brettp

  • Resolution set to fixed
  • Status changed from new to closed

(In [svn:8750]) Fixes #3094, Refs #3111. Clicking outside a popup closes the visible popups.

comment:2 Changed 2 years ago by anirupdutta

  • Resolution fixed deleted
  • Status changed from closed to reopened

Click on the icon of the user.It wont work.Fixed one problem,created another.Disabled all links.However if you right click and open it in a new tab it would work.

comment:3 Changed 2 years ago by brettp

This was the effect I had in mind. You can close the popup by clicking outside of it, but I don't think that should fire events if you happen to click on a link. I'll investigate how other services do this.

comment:4 Changed 2 years ago by anirupdutta

This has also disabled the drop down login.

comment:5 Changed 2 years ago by brettp

Other systems don't block the click events, so I'll remove that.

comment:6 Changed 2 years ago by brettp

  • Milestone changed from Elgg 1.8 to Elgg 1.8 Beta

comment:7 Changed 2 years ago by brettp

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [svn:8790]) Fixes #3094. Removed event blocking code for popups.

comment:8 Changed 2 years ago by brettp

(In [svn:8842]) Fixes #3234, refs #3094. Added the inTarget code back to the popup closing function.

Note: See TracTickets for help on using tickets.