Opened 2 years ago
Closed 2 years ago
#3096 closed Defect (fixed)
find better name for list/body view
| Reported by: | cash | Owned by: | ewinslow |
|---|---|---|---|
| Priority: | low | Milestone: | Elgg 1.8 Beta 2 |
| Component: | Core | Version: | Github Master |
| Severity: | trivial | Keywords: | |
| Cc: | brett@… | Difficulty: | trivial |
Description
As discussed this is a poor name as it is used outside of lists. 'summary' was the best choice so far. We could always ask for developer input during the beta.
Change History (9)
comment:1 Changed 2 years ago by cash
comment:2 Changed 2 years ago by cash
- Milestone changed from Elgg 1.8 Beta to Elgg 1.8
Leaving this one open for now in case we want to change before final release
comment:3 Changed 2 years ago by cash
(In [svn:8691]) Refs #3096 removed the list directory since we moved the body view out
comment:4 Changed 2 years ago by ewinslow
Thinking about this more, I'm more convinced that object/elements/summary is a good way to go.
Groups could have their own: group/elements/summary. It can borrow from the object's view in core if we want to keep things dry, but then it can be overridden for groups and not objects. Providing that flexibility seems like a good idea.
Same for users.
comment:5 Changed 2 years ago by cash
I'm fine with that.
comment:6 Changed 2 years ago by cash
- Milestone changed from Elgg 1.8.0 to Elgg 1.8 Beta 2
any solution needs to be backward compatible
comment:7 Changed 2 years ago by ewinslow
- Owner set to ewinslow
- Status changed from new to assigned
comment:8 Changed 2 years ago by cash
(In [svn:9173]) Refs #3096 Moved page/components/summary to object/elements/summary. Left
page/components/summary for backwards compatibility. Plugins will
eventually need to be updated to use $type/elements/summary
comment:9 Changed 2 years ago by cash
- Resolution set to fixed
- Status changed from assigned to closed
(In [svn:9174]) Fixes #3096 added user and group summery views an updated plugins to use the new view locations
(In [svn:8680]) Refs #3096 using 'summary' instead of list/body