We have moved to Github. Please open tickets there.

Opened 2 years ago

Closed 2 years ago

#3138 closed Enhancement (fixed)

'owner' or 'all' at the end of group urls?

Reported by: ewinslow Owned by: cash
Priority: normal Milestone: Elgg 1.8 Beta 2
Component: Core Version: Github Master
Severity: minor Keywords:
Cc: brett@… Difficulty: easy

Description

e.g.: /bookmarks/group/$guid/owner

This seems gratuitous?

Change History (11)

comment:1 Changed 2 years ago by cash

what if we added another page for bookmarks (take blog archives as an example)? Maybe group members "like" bookmarks and we display a page the most liked at /bookmarks/group/$guid/liked

comment:2 Changed 2 years ago by ewinslow

/bookmarks/liked/$guid?

comment:3 Changed 2 years ago by cash

But that prevents you from doing /bookmarks/liked/ewinslow which you may like more than /bookmarks/liked/456574

Do we really want to give up this flexibility to make the group URLs a little shorter?

comment:4 Changed 2 years ago by ewinslow

It's not about having a shorter url so much as removing gratuitous information from the url. How about this?

/bookmarks/group/12345
/bookmarks/group/12345/liked

or, if you prefer,

/bookmarks/group/12345/all
/bookmarks/group/12345/liked

At least this is consistent with the site-level urls (i.e. /bookmarks/all, /bookmarks/liked)

comment:5 Changed 2 years ago by cash

I think you just made my point in the last comment. The second set of URLs is exactly what I'm trying to do. I'm not a fan of leaving off the last segment because at times we have changed the default page (should it be all or should it owner). When we make the change, people who have bookmarked the all page suddenly end up on the owner page.

comment:6 Changed 2 years ago by ewinslow

That's fair.

In that case what I'm saying is that "all" is a better name than "owner" _.

comment:7 Changed 2 years ago by cash

  • Summary changed from Remove 'owner' from the end of group urls to 'owner' or 'all' at the end of group urls?
  • Type changed from Defect to Enhancement
  • Version changed from 1.7 to SVN Trunk

Since we're publishing plugin guidelines soon we should make a decision.

I chose 'owner' because that is what is used for users. I can see the use of 'all' because it does display all of a group's stuff.

Get your votes in now!

comment:8 Changed 2 years ago by cash

  • Milestone changed from Needs Review to Elgg 1.8 Beta 2

This needs to be decided now.

comment:9 Changed 2 years ago by brettp

All.

comment:10 Changed 2 years ago by cash

  • Owner set to cash
  • Status changed from new to assigned

comment:11 Changed 2 years ago by cash

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [svn:9133]) Fixes #3138 using 'all' for group listing urls

Note: See TracTickets for help on using tickets.