We have moved to Github. Please open tickets there.

Opened 2 years ago

Closed 2 years ago

#3169 closed Defect (worksforme)

Migration doesn't work for group forum posts

Reported by: brettp Owned by:
Priority: normal Milestone: Elgg 1.8 Beta
Component: Core Version: Github Master
Severity: minor Keywords:
Cc: brett@… Difficulty: easy

Description

Forum topic doesn't get the first "reply" annotation. See attached.

Attachments (1)

forum posts.png​ (227.0 KB) - added by brettp 2 years ago.

Download all attachments as: .zip

Change History (6)

Changed 2 years ago by brettp

comment:1 Changed 2 years ago by cash

Just a guess - is the group's upgrade function not registered for the plugin hook because the new plugin objects haven't been created?

comment:2 Changed 2 years ago by cash

I have confirmed that this is the problem. Possible solution: write an upgrade script that checks if the groups_init function exists, if not tries to manually load its start file and register the upgrade script. Is that too ugly?

comment:3 Changed 2 years ago by cash

Never mind. We do need to load the plugins. This is also causing my upgrade script for #3193 to fail. This is going to get ugly.

New suggestion:

  • in upgrade.php check for the existence of a new plugin object
  • if none, unregister all the init, system event handlers and bootstrap load the active plugins using the old method
  • trigger the init, system event
  • go on our merry way

2nd suggestion:

  • stop the upgrade after the plugin objects are upgraded and have it forward to run the upgrade again picking up where it left off

comment:4 Changed 2 years ago by ewinslow

I vote for #2 :)

comment:5 Changed 2 years ago by cash

  • Resolution set to worksforme
  • Status changed from new to closed

Closing for #3241

Note: See TracTickets for help on using tickets.