elgg-icon does not interact well with floated items

[cash]

check out the friend river entry. It is supposed to be avatar arrow_icon avatar. Because the avatar is floated, the order is incorrect. Should elgg_view_icon() take an optional float parameter?

How do we want to handle RTL sites for floats? Using .right and .left is going to get us in trouble.

[ewinslow]

.float and .float-alt?

As for the friend river entry, this is because the avatar icons are floated and the arrow icon is not, correct?

[cash]

yes on the avatars floated and the icon is not.

float and float-alt should work. Would be useful to have someone with RTL experience provide some input

[cash]

elgg_view_icon($name, $float = false) either floats the icon or not. We need three options: float, float-alt or no float.

[ewinslow]

What about making it a "class" parameter instead? You can pass float, float-alt, or nothing. And it allows us to pass other things in the future if we ever find the need to.

[brettp]

We can keep the .left and .right then add .float and .float-alt later, so bumping this.

[cash]

.float and .float-alt have been added. We need to remove .right and .left. We really should have updated elgg_view_icon() before the 1.8.0 release if we were going to change it. Do we live with only supporting float/no float instead of the more flexible passing of a class name?

[brettp]

Let's make the change to pass a class name.

[cash]

Fixes #3178 updated elgg_view_icon() to take an optional class

Changeset: 6fab3ed243d3e2688916dcb65141e37bef1cc4c3

[cash]

Fixes #3178 updated elgg_view_icon() to take an optional class

Changeset: 6fab3ed243d3e2688916dcb65141e37bef1cc4c3